nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Urgency graph message does not match UG's description #1425

Open nus-pe-bot opened 5 months ago

nus-pe-bot commented 5 months ago

Details:

image.png

image.png

Suggestion:


[original: nus-cs2103-AY2324S2/pe-interim#1806] [original labels: type.FunctionalityBug severity.Medium]

Joseph31416 commented 5 months ago

Team's Response

We have changed the severity from medium to low, and type from functionality to feature flaw for the following reason:

The behaviour of the application is correct and matches the UG description.

This is how urgency is calculated from the user guide (note the last line):

image.png

So indeed, overdue loans are not used for urgency calculation. By "due" in the image, we were referring to an upcoming loan, not an overdue loan (which is why we did not use "overdue"). However, we acknowledge that this could have been made clearer in the display message to avoid misinterpretation, by saying "no upcoming loans to analyze". Thus, it falls into the feature flaw category.

For the reason why we do not consider overdue loans in our calculation of the Urgency index, this is because that would heavily skew the URGENCY_ALL parameter, since overdue loans would be infinitely more urgent than due (i.e. upcoming) loans. As such, a client with a loan that was due, say, the next day might show very low urgency due to the skewing by overdue loans, which is not the behaviour we want from the app as a moneylender would want to monitor these clients - after all, their loans are about to expire and it is vital to remind them before they incur the overdue penalty. For checking if a user has a high number of overdue loans, we already have an index for that - the Reliability index! Hence, it is always possible to tell the proportion of overdue loans of the user, and so it is not necessary for the Urgency index to do this job as well.

image.png

This is a duplicate of issue 4043

As for severity, this causes a minor inconvenience only to the user as the user guide clearly tells the user how the urgency index is calculated. As such, the only way for a user to be misled by the choice of wording of "due" loans would be if they did not read the user guide, which is an extremely unlikely scenario as the user would probably not be able to discover the analytics command without reading the user guide. Thus, we are marking it as Severity.Low (not VeryLow as even though it is a wording/English issue, we do understand that the choice of words could affect understanding of the app). We hope that our decision makes sense, thank you!

Duplicate status (if any):

--