nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Phone numbers allow single digit inputs #1444

Open nus-pe-bot opened 4 months ago

nus-pe-bot commented 4 months ago

Realistically, phone numbers should be at least 3 digit long, but typing "0" into the phone attribute is accepted.


[original: nus-cs2103-AY2324S2/pe-interim#1185] [original labels: severity.Low type.FeatureFlaw]

Bandov commented 3 months ago

Team's Response

Our app is for Genealogists, with possibly large family trees, that span many generations. This means that a genealogist may have a relative who either lived in an older time period, or live in a country with an unorthodox phone system, past present or future.

Phone numbers can have as little as 1 digit (see link provided) in private phone systems. Thus, a relative may have only such a phone number, due to their location, or time period. Maybe they even invented the first phone.

Therefore, unless it can be proven that no person in history (covered by our use case) could be contacted by a single digit phone number, it is not a feature flaw as the ability to record the details of ANYONE is a main goal of our app.

It might be said that we should give a warning. In that case, not in scope because it's not very important for our use case.

Duplicate status (if any):

--