nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Overzealous phone number validation blocking inputs less than 7 digits #1548

Open nus-se-script opened 6 months ago

nus-se-script commented 6 months ago

Attempts to enter phone numbers in various valid formats such as "1234567" are blocked by the application. This restriction does not add value and limits user flexibility in inputting phone numbers that are less than 8 digits which is possible for companies phoneline.

add /com shopback /desc create new recommendation engine /status ongoing /poc jane yeo /email hr@tiktok.com /phone 999 /loc remote /role Software Intern

image.png

Rationale: severity.Medium as this might occasionally frustrate and inconvenience users especially if the company has a special phone line less than 8 digits to be input.


[original: nus-cs2103-AY2324S2/pe-interim#1260] [original labels: severity.Medium type.FeatureFlaw]

LWS49 commented 6 months ago

Team's Response

We don't find phone numbers with less than 7 digits occuring other than for speed dial options (999, 995) which will not be a person's actual contact number. This is a contrived issue that should not happen on a regular user's use of our application, thus the frequency of needing to add such a number will be close to 0. Furthermore, should it be the case, we have both remark and description fields to capture these type of information.

image.png In addition, international phone numbers have a minimum of 7 digits, so cases where the contact phone number has less than 7 digits is extremely scarce.

Duplicate status (if any):

--