nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Different people with same phone and email are allowed #1751

Open nus-se-script opened 7 months ago

nus-se-script commented 7 months ago

Description

Adding a person with the same fields but different names as another existing person is allowed in the application. But realistically, there should not exist two people with the same phone number, email etc.

Steps to reproduce

  1. input add n/Person 1 p/98765432 e/johnd@example.com m/Computer Science
  2. input add n/Person 2 p/98765432 e/johnd@example.com m/Computer Science

Expected

The application should have multi-criteria checking to ensure that Person 2 cannot be added after adding Person 1.

Actual

Person 2 is added successfully after Person 1.

Screenshots

image.png


[original: nus-cs2103-AY2324S2/pe-interim#2203] [original labels: type.FunctionalityBug severity.Medium]

c-wenlong commented 6 months ago

Team's Response

On page 44.

Screenshot 2024-04-22 at 15.37.38.png

We have stated within our planned enhancements that we will be doing the said validations.

Duplicate status (if any):

--