nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Overzealous validation #1925

Open nus-se-script opened 4 months ago

nus-se-script commented 4 months ago

Phone number field show allow from common symbols used in phone numbers such as '+' and '-' for country/area codes.

Steps to repdroduce:

  1. enter following command to CLI 'update u/saa p/+65 91234567 e/johndoe@example.com'

Expected output: Valid update Actual output : Invalid phone number![](url) Screenshot 2024-04-19 at 4.25.36 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#2447] [original labels: severity.Low type.FeatureFlaw]

tejas-1405 commented 4 months ago

Team's Response

Given that the application is aimed towards social workers, it is already very unlikely that their clients will have overseas numbers. Furthermore, if there is a requirement for overseas numbers, one can always use this notation for international numbers:

"Country codes are dialed before the national telephone number, but require at least one additional prefix, the international call prefix which is an exit code from the national numbering plan to the international one. In most countries, this prefix is 00, an ITU recommendation; it is 011 in the countries of the North American Numbering Plan while a minority of countries use other prefixes." - From Wikipedia

Therefore, we do think that this bug is Not In Scope, as the current feature does already support most international numbers and the chance of a client having an international number is really small.

Duplicate status (if any):

--