nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Client name requirements are too restrictive #2187

Open nus-se-script opened 4 months ago

nus-se-script commented 4 months ago

Currently client name requirements are too restrictive as they only allow for alphanumeric characters and spaces. This means that some common name formats, especially in Singapore, will not be accepted.

For instance, 's/o' or 'd/o' are common for names of Singaporeans who are Indian. However, the application doesnt accept this as a valid name

Steps to reproduce:

  1. add --name=Theodore Koo s/o Charles --phone=98001715 --email=theodore@example.com --addr=Prince Street, Block 144, #19-14 --tags=Disabled --note=Lactose Intolerant

Resultant output: Screenshot 2024-04-19 at 4.36.36 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#1801] [original labels: severity.Medium type.FeatureFlaw]

vannykin commented 4 months ago

Team's Response

There is a work-around which is to save the full name in the notes. image.png

Another work-around is to say "son of" or "daughter of" instead of "s/o" or "d/o".

This enhancement is of lower priority than what we had planned for in V1.4 as it would've altered the behavior of the application during the feature freeze period.

Duplicate status (if any):

--