nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Phone number format does not allow for country codes #2189

Open nus-pe-bot opened 4 months ago

nus-pe-bot commented 4 months ago

Occasionally, there might be a need to keep in touch with foreign clients or contacts, especially in the context of social work.

However, SWEE does not currently support country codes since phone numbers can only contain numbers. Without such a functionality, it could be incredibly difficult for the user to know the country code extension associated with a particular number, limiting the scope of the app to local numbers and contacts only which could inevitably fall short in use case for some social workers.

Steps to reproduce:

  1. add --name=Theodore Koo --phone=+6598001715 --email=theodore@example.com --addr=Prince Street, Block 144, #19-14 --tags=Disabled --note=Lactose Intolerant

Resultant output:

Screenshot 2024-04-19 at 4.50.54 PM.png

To alleviate this, there could be workarounds that the team could provide in order to not restrict the application's use case!


[original: nus-cs2103-AY2324S2/pe-interim#1804] [original labels: severity.Medium type.FeatureFlaw]

vannykin commented 4 months ago

Team's Response

There is an obvious work-around to this, which is to remove the "+" sign and just input the phone number as "6598001715".

Alternatively, the country code can be added in the note field.

We disallowed symbols like "+" to ensure that the input is a valid phone number.

Duplicate status (if any):

--