search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Application refuses to start on certain `tatoolkit.json` corruption instead of handling it gracefully #2355

Open nus-pe-bot opened 3 months ago

nus-pe-bot commented 3 months ago

About

If more than 13 values are present in the attendance field, the application fails to start at all:

image.png

image.png

Expected

The application backs-up the database, launches with a message saying the database is corrupted, and give the user options to contact the developers/deal with the problem.

[original: nus-cs2103-AY2324S2/pe-interim#2978] [original labels: type.FunctionalityBug severity.VeryLow]

g-tejas commented 3 months ago

Team's Response

Hi, Thank you for your kind feedback! In the UG, we specifically mentioned that certain edits can cause the TAToolkit to behave in unexpected ways, and that we warn users to edit the data file only if they are confident that they can update it correctly. Furthermore, as mentioned by Prof Damith here: https://github.com/nus-cs2103-AY2324S2/forum/issues/917 , there is no requirement to support invalid edits of the JSON file.

Duplicate status (if any):

--