search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

phone number minimum should cater to the shortest possible phone number globally #246

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

Steps to Reproduce

  1. Start the application with the default data.
  2. Update the phone number of a library user: edit 1 p/123

Expected Behavior

The application is taking into account invalid phone number lengths. Perhaps the application can minimally accept the shortest possible phone number globally.

Actual Behavior

The application accepts phone numbers of length 3 which is not a valid phone number length minimally.

image.png

[original: nus-cs2103-AY2324S2/pe-interim#320] [original labels: severity.Low type.FeatureFlaw]

Darkarche3 commented 2 months ago

Team's Response

Thank you pointing this out.

Our team has decided to put NotInScope as response.

We have also notified this issue under future enhancement:

image.png

Referencing the second point, we plan to adjust the range of acceptable length for phone numbers in the future enhancements.

Note: While response.NotInScope are not counted against the dev team, they can earn a small amount of consolation marks for the tester. The other three do not affect marks of either the dev team or the tester.

Duplicate status (if any):

--