nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Overzealous phone number validation blocking symbols in input #2501

Open nus-se-script opened 7 months ago

nus-se-script commented 7 months ago

Attempts to enter phone numbers in various valid formats such as

 add /com shopback /desc create new recommendation engine /status ongoing /poc jane yeo /email hr@tiktok.com /phone +65 90890212 /loc remote /role Software Intern

are blocked by the application. This restriction does not add value and limits user flexibility in inputting phone numbers as they see fit.

image.png

Rationale: severity.Medium - This might occasionally frustrate and inconvenience users especially if the company is from another country (which may be quite often), requiring other country codes to be input.


[original: nus-cs2103-AY2324S2/pe-interim#2077] [original labels: severity.Medium type.FeatureFlaw]

LWS49 commented 7 months ago

Team's Response

We agree that this is a valid issue. However, internships that have an international phone number as a contact are rare, since international internships typically use email as a POC. In addition, the Remark field is intended for rare cases like this. Therefore, we believe that this is NotInScope, since accounting for these rare cases with workarounds has a lower priority than the work already done in v1.4.

Duplicate status (if any):

--