nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Addition of appointment for invalid dates (i.e. before today) #2724

Open nus-pe-bot opened 6 months ago

nus-pe-bot commented 6 months ago

Steps to recreates:

  1. Add the person e.g. addPatient i/T0123456A n/John Doe b/2001-01-30 p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/insulin t/panadol

  2. Add the appointment (with a date prior today) e.g. addAppt i/T0123456A d/2024-02-20 from/11:00 to/11:30 t/Medical Check-up note/May come earlier

image.png

Expected:

Warning / Error message. This is because creating an appointment before today does not make sense. There is no use case (e.g. back-logging) to support this "feature" as well.

Actual:

Considered as valid input.


[original: nus-cs2103-AY2324S2/pe-interim#2276] [original labels: severity.Medium type.FeatureFlaw]

dayn-1 commented 6 months ago

Team's Response

Hello, thank you for raising this issue.

This was covered in the FAQ section of the UG:

image.png

The observations made in the bug report are expected behaviour and within the premise of a valid input, as covered in the UG.

However, including a warning message is a possible improvement that the team acknowledges. Nevertheless, fixing it is less important than the work done in the current version of the product.

Response not in scope.

In any case, the severity has been dropped to severity.Low as it is unlikely to affect normal operations of the product.

Duplicate status (if any):

--