nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Error message is too broad for invalid interview date #291

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

Steps to reproduce

execute:

add c/FoodPanda p/12345678 e/panda@food.com a/CBD t/I jd/Front End Intern d/15-04-2024 0900 id/6 months s/500 n/-

Expected

An error message only indicating the date is in the past, and not wrong format.

Actual

An error message indicating that the input is either wrong format OR in the past.

Error parsing interview date: Interview Date & Time needs to follow this pattern : dd-mm-yyyy HHmm
Interview Date & Time cannot be before today's date!

image.png

Suggestions

The warning should not be too broad to the user as it could give them the wrong idea on what's the error is all about.

Instead, I think it would be better if the error message shown only indicates that the input is in the past in this example.


[original: nus-cs2103-AY2324S2/pe-interim#380] [original labels: type.FunctionalityBug severity.VeryLow]

ashleygoh1 commented 2 months ago

Team's Response

No details provided by team.

Duplicate status (if any):

Duplicate of #4166