nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Overzealous input validation for phone number #3321

Open nus-se-script opened 4 months ago

nus-se-script commented 4 months ago

Based on the given context, the restriction on phone number that excludes special character seems to be too restrictive. It's possible that the user wants to record a temporary contact of a staff that is currently oversea.

Screenshot 2024-04-19 at 5.01.22 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#2769] [original labels: severity.Low type.FeatureFlaw]

iynixil commented 4 months ago

Team's Response

Thanks for raising this. Our target users and subjects are primarily within the same environment(Same university, more specifically in this case NUS). Which means it usually localised to the same country (in this case Singapore) and hence do not need to specify the country code, as it would be inherently understood that it is from the same country.

If the staff is moving overseas or currently overseas permanently, the staff will not be a subject of concern to the user. This is because it mostly that the staff would not be on duty within the educational institution itself and hence not relevant to the user. Thus the staff contact would not be added.

If the staff has temporarily gone overseas, with a temporary overseas number, the local contact number will still be valid and can remain as part of the contacts. Though it may not be preferred mode that the staff may want the user to contact them, there are other means available to contact the staff. Another good reason to not change to the temporary overseas number is to ensure consistency of the staff details. As the overseas number will not be relevant or valid once the staff are back (in the host country).

Duplicate status (if any):

--