search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Incorrect detection of duplicate contacts #3714

Open nus-pe-bot opened 4 months ago

nus-pe-bot commented 4 months ago

Description

Duplicate contacts are detected by same name or same github username, however, the detection of the github username is not case-sensitive. If I recall correctly, github usernames are not case-sensitive. (ie. johndoe is equals to JOHNDOE)

Steps to Reproduce

  1. Launch the application.
  2. Enter command add n/john p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/johndoee123
  3. Enter command add n/John p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/Johndoee123

Expected

Should indicate as duplicate.

Actual

image.png

Note

-

[original: nus-cs2103-AY2324S2/pe-interim#3108] [original labels: type.FunctionalityBug severity.Low]

yuechen2001 commented 4 months ago

Team's Response

image.png

I am not sure what is the issue here, if the detection of GitHub usernames matches the nature of github usernames, which is not case sensitive.

Duplicate status (if any):

--