Open nus-pe-bot opened 4 months ago
I believe this is tagged under deliberate sabotage, and that people wouldn't purposely put their timings as 1 minute long. If we were to cater for this, we would then have to discuss and deliberate on what exactly would we consider appropriate timing ranges, which we do not want to dictate and instead have users control over.
--
Steps to reproduce
clear
add n/Taufiq Mohammed p/81234567 e/taufiq@taufiq.com a/123, Clementi Road, 123
add_module i/1 m/CS2040S
add_timing i/1 m/CS2040S d/Sun st/0000 et/2359
Note here that any invalid timing would still work i.e. setting the time from 0000-0759 or setting a timing that is only one min long (1200-1201)
Explanation In the context of this application, the timing is used to indicate the class' timings. NUS does not have classes from midnight up to 8am. However, i am able to input this. Though this may only affect a small number of users who accidentally key in an invalid timing, it would still be better to throw an error here. This issue carries onto setting the module timing to be longer / shorter than the actual time classes may take i.e. setting the timing to be 1 minute only.
Screenshots
[original: nus-cs2103-AY2324S2/pe-interim#3262] [original labels: severity.Low type.FeatureFlaw]