search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Find command unspecified behaviour #3958

Open nus-pe-bot opened 7 months ago

nus-pe-bot commented 7 months ago

Command: find d/|

It finds all persons who use a | separator in their drug allergy field.

[original: nus-cs2103-AY2324S2/pe-interim#4990] [original labels: severity.Low type.FeatureFlaw]

raysonchia commented 7 months ago

Team's Response

Thanks for your report. The reported command find d/| is indeed a valid command and the result of find d/| is working as specified in the user guide.

Here are the drug allergy specifications from the user guide: SCR-20240421-qbxi.png According to our UG, the | character are accepted and should be used to separate multiple drug allergies. This makes it a valid keyword in the drug allergy field that is searchable in the find d/ command.

As documented in the UG, the find command was designed to return patients that contain any of the given keywords. SCR-20240421-qlid.png Since | is recognised and utilised within the drug allergy field, it is a valid searchable term. Therefore, find d/| correctly returns all patients whose drug allergy field includes |. This is not unintended but a consequence to our documented design decisions to use | as separators for the drug allergy field and for find to return all patients with matching keywords. More examples could be added to the UG to explain this behaviour.

Duplicate status (if any):

--