nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

ADD Feature does not account for adding in drug allergies containing prefix #4030

Open nus-se-script opened 3 months ago

nus-se-script commented 3 months ago

Steps to reproduce:

Expected:

Actual:

Screenshots:

image.png

This is problematic as there are medicine that have similar drug names that uses the same prefix. You can consider supporting this for better convenience and usability for your users. One way you can do is by using a more specific prefix, or by having a warning rather than blocking it.


[original: nus-cs2103-AY2324S2/pe-interim#5071] [original labels: severity.Low type.FeatureFlaw]

jmsandiegoo commented 3 months ago

Team's Response

Although it might seem like an issue, /p is a reserved keyword with respect to the command format as stated in the UG. The drug allergy can contain reserved prefix values but need to make sure that it is not preceded by the space at the start as that would be considered a prefix parameter according to the command format. Perhaps an escape character functionality can be implemented in the future releases to allow spaces beforehand. Thus, this can be considered an enhancement and can be seen as NotInScope

Duplicate status (if any):

--