nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

ADD Feature does not account for proper validation checks on NRIC Number #4032

Open nus-se-script opened 4 months ago

nus-se-script commented 4 months ago

Steps to reproduce:

Expected:

Actual:

Screenshots:

image.png

This is problematic as this could have been a typo from the users' part. You can consider supporting this for better convenience and usability for your users. One way you can do is by throw a warning message for such mismatch.


[original: nus-cs2103-AY2324S2/pe-interim#5073] [original labels: severity.Low type.FeatureFlaw]

jmsandiegoo commented 4 months ago

Team's Response

You are right regarding the NRIC digits not having appropriate validation. It has actually been taken note of during PE-D and has been added into the DG's Planned enhancements and thus considering this as NotInScope.

image.png

Duplicate status (if any):

--