nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Name should not be a unique identifier #4041

Open nus-pe-bot opened 6 months ago

nus-pe-bot commented 6 months ago

In real life, a moneylender can have multiple clients with the same name.

This may cause inconvenience to some users when name is the unique identifier.

Screenshot 2024-04-19 at 17.06.15.png


[original: nus-cs2103-AY2324S2/pe-interim#3362] [original labels: severity.Low type.FeatureFlaw]

Joseph31416 commented 6 months ago

Team's Response

Thank you. This is true, because we still use the same isSamePerson() method from AB3. We decided this issue is severity low because there are some less desirable workarounds, such as using John Doe with two spaces. If the moneylender has two clients of the same name, they might also just distinguish them with some suffixes too, so either way this should not affect normal operation much.

Duplicate status (if any):

--