search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Unknown classes in person class diagram #4168

Open nus-pe-bot opened 2 months ago

nus-pe-bot commented 2 months ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

In the person model class diagram, what are the classes Department; Products; TermsOfServices; Skills, etc. ? You should represent them as separate classes with their own structure

[original: nus-cs2103-AY2324S2/pe-interim#5238] [original labels: severity.Low type.DocumentationBug]

purivirakarin commented 2 months ago

Team's Response

As the Client, Supplier, and Employee extends from Person class and does not have many more fields that specifically belongs to each subclass, therefore, it is more readable to just group these Client, Supplier, and Employee classes. Also, as Person is an abstract class in NetConnect, showing limited fields that Person in general could has does not give much practical information. Instead, as a person in NetConnect has to only be categorized into either Client, Supplier, or Employee, we therefore could show what are all the fields that they can have.

Duplicate status (if any):

--