nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Inconsistent command keyword design #4874

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

For the archive list related features, command for adding an archive student is "archive", while for unarchive action, the command is "unarchived". It is not very intuitive in making the two different, and would add in more effort for the users to remember and distinguish.

image.png

image.png


[original: nus-cs2103-AY2324S2/pe-interim#4383] [original labels: type.FeatureFlaw severity.VeryLow]

Wongqingyee commented 2 months ago

Team's Response

Thanks for the feedback. Since archive command is only applicable for the persons list, and unarchived, delete_archived, edit_archived, and clear_archived are only applicable to the archived list. I was trying to differentiate the command between persons list and archived list with the word archived (can refer to the attached below for the implementation).

This is issue was brought up during the PE dry run and we can't really changed this due to the feature freeze.

image.png

Duplicate status (if any):

--