search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Not blocking invalid fields for find command #4894

Open nus-se-script opened 7 months ago

nus-se-script commented 7 months ago

input : 1) insert a person with diabetes condition 2) find con/diabetes / output : shows 0 person listed.

Expected that the system would either block the command, telling me that I have entered an invalid field or at least warn me that I have inputted an invalid field or typo.

However, there is no warning and the system reports that there is no such person.

This is problematic as there is in fact someone with diabetes onthe list. fast typist can easily make such typos and not warning the user would lead them to false believe there is no one that matches their description

image.png

[original: nus-cs2103-AY2324S2/pe-interim#4417] [original labels: severity.Low type.FeatureFlaw]

laney0808 commented 7 months ago

Team's Response

Thank you for bringing this up, this is a valid concern indeed. The app is responding as such as it interprets "diabetes /" as the condition needing to be found, not knowing that "/" indicates the presence of another field. While we agree that including checks for invalid fields would greatly enhance user experience, we think that such typos including "/" are trivial and unlikely. Moreover, it has been mentioned in the user guide that conditions should be separated with commas, so a message such as "0 persons listed" should prompt the user to realise the error in his/her previous input and take more care when typing his/her next input.

Duplicate status (if any):

--