nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Overzelous input validation for phone #4977

Open nus-pe-bot opened 6 months ago

nus-pe-bot commented 6 months ago

In real life scenario, there may be instances where a person have multiple phone numbers. I feel like restricting this may not add value, but allowing it does.

image.png

image.png

Refer to this: https://github.com/nus-cs2103-AY2324S1/pe-dev-response/issues/4987


[original: nus-cs2103-AY2324S2/pe-interim#4540] [original labels: severity.Low type.FeatureFlaw]

aureliony commented 6 months ago

Team's Response

Firstly, our application actually supports multiple phone numbers as required by logistics contacts who may have an office and personal phone number, e.g. +65-67823701, +65-92131867.

Secondly, regarding the screenshot that you provided, adding extra information such as (Office) and (Home) would interfere with our copy command, making it more inconvenient for the user to copy a phone number. We recognize that a more complex system such as having multiple fields for different types of phone numbers is possible, but this is not in scope for v1.4.

Duplicate status (if any):

--