nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

PhoneNumber: Validation #4999

Open nus-se-script opened 4 months ago

nus-se-script commented 4 months ago

How to reproduce Edit the phone number to be a many-digits phone number e.g. edit 1 c/62974362378465238568324658142658762438751642831615842736587423687563488456786875618568756868168652782564876598476

Actual The application accepts without errors/warnings.

Expected There could be more validation in case the user unintentionally saves other information such as a client ID or other numbers that are very huge numbers into the phone field, then the application just accepts it.

Screenshot 2567-04-19 at 16.56.34.png


[original: nus-cs2103-AY2324S2/pe-interim#4575] [original labels: severity.Low type.FeatureFlaw]

yorklim commented 4 months ago

Team's Response

When the client successfully edits the phone number, he will show up in the client display panel with the updated info. The user can easily see that he has keyed in a large phone number wrongly. In addition, the user has the intention of editing the phone number, hence overriding the previous phone number is not an issue. He can also easily fix his mistake by editing the phone number again.

Duplicate status (if any):

--