nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Date validation does not account for the HHmm to check if it's in the past #502

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

Steps to reproduce

At this point of testing, the time is 5:05 pm.

Execute edit 1 d/19-04-2024 1200

Expected

It should give the user a warning that the date input cannot be in the past.

Actual

The edit command executes successfully despite the entry being in the past.

Edited internship application entry: Grab; Phone: 99999999; Email: test@test.com; Address: 311, Clementi Ave 2, #02-25S(123456); Tags: Online Assessment; Job Description: Software Developer intern; Interview Date: 19-04-2024 1200; Internship Duration: test; Salary: 1000; Note: Company CEO is John Doe, techteam lead is Alex Yeohn/Company has 500 employee

Note how the interview date here is in the past.

image.png

Suggestion

The validation should also account for time to check if the input is in the past.


[original: nus-cs2103-AY2324S2/pe-interim#382] [original labels: type.FunctionalityBug severity.Low]

eunrcn commented 2 months ago

Team's Response

Dear tester, our error message explicitly mentions only date instead of date and time

Screenshot 2024-04-20 at 4.51.39 PM.png

Duplicate status (if any):

--