nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Not Allow Editing Valid Telegram Name #5184

Open nus-se-script opened 6 months ago

nus-se-script commented 6 months ago

Problem: For telegram name, "BerniceYu" and "berniceYu" should be 2 different persons. When "@berniceYu" exists, I should still be allowed to change another person's telegram name to "BerniceYu" or "BERniceYu" as long as the cases are different according to real life example. However, the app stops me from editing someone else's telegram to "BerniceYu" when "berniceYu" exists. This causes inconvenience to users.

Command: edit 1 t/BerniceYu Expected: Changed successfully. Actual: "A person with same phone, email, or telegram, has already exists in the Dormie."

Screenshot:

Screenshot 2024-04-19 at 5.05.29 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#4887] [original labels: type.FunctionalityBug severity.Medium]

donwong2308 commented 6 months ago

Team's Response

In the real world, Telegram treats the username as case-insensitive.

Hence, @BerniceYu is the same as @berniceYU. Therefore, attempting to edit a telegram user name to @berniceYU when @BerniceYu exists is not allowed.

image.png

Furthermore, Dormie's User Guide specified that the telegram handle is case-insensitive as well.

Screenshot 2024-04-21 at 7.37.36 PM.png

If deemed necessary, we think that this issue should be severity.Low because users can still find the desired person's telegram

image.png

Duplicate status (if any):

--