nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Scheduling allows for adding names of clients/contacts not in the contact list #5222

Open nus-pe-bot opened 4 months ago

nus-pe-bot commented 4 months ago

Description: as stated in topic.

Precondition: no contact in the list named Emily exists.

Steps to reproduce:

  1. schedule add h/Meet n Greet t/4/5/2024 0000 d/Meet at the spot n/Emily

Expected behaviour: Since emily is not in the contact book, perhaps the command should not execute since we do not know the client's contact details at all.

Actual behaviour: schedule add command executes successfully

Screenshot 2024-04-19 at 5.01.28 PM.png

Notes: Perhaps some form of cross referencing could be useful here. If we have a meeting scheduled with a client, as a user, I would expect to have their contact details in the app first so that I can contact them easily.


[original: nus-cs2103-AY2324S2/pe-interim#4948] [original labels: severity.Medium type.FeatureFlaw]

Rishit02 commented 4 months ago

Team's Response

It may be possible that the social worker is going to meet this client for the first time, hence, does not have all of their contact details which is why we allowed them to add clients that are not in the client list. We can implement this feature in the future, however, fixing it is less important than the work done in the current version of the product. Therefore, we would consider this NotInScope We would also suggest changing the severity to Low as it only serves as a minor and rare inconvenience to the user.

Duplicate status (if any):

--