search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Duplicate task checking is not case-sensitive #536

Open nus-pe-bot opened 7 months ago

nus-pe-bot commented 7 months ago

As mentioned in the title, the checking for duplicate tasks is not case-sensitive. This may result in actual duplicate tasks when it is actually just a difference in case sensitivity.

To reproduce:

  1. addtask n/task1 d/something p/1 by/18-02-2022 12:00
  2. addtask n/Task1 d/something p/1 by/18-02-2022 12:00

image.png

I suggest that the duplicate check for task names be made case-sensitive and/or be extended to the deadline of the task as well (a task is duplicate if and only if the name and the deadline of both tasks are equal)

[original: nus-cs2103-AY2324S2/pe-interim#407] [original labels: type.FunctionalityBug severity.Medium]

chin-herng commented 6 months ago

Team's Response

We intended for two tasks to be considered different if the casing for the task names is different. The fact that both commands succeed is intended, therefore this is certainly not a functionality bug.

We claim that this is also not a feature flaw, because the meaning of a task might change simply by changing the casing in the task name. For example, "Write email to teammates" and "Write email to TEAMMATES" are different tasks. The latter likely refers to the task of sending an email to the TEAMMATES dev team.

Duplicate status (if any):

--