nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

[Phone input] Phone input should be validated to not exceed unreasonable size #5389

Open nus-pe-bot opened 5 months ago

nus-pe-bot commented 5 months ago

Hello!

I do not think this is too big of a deal, but perhaps some input validation constraints for phone number should be good too.

I ran the command edit S1234567B p\00072384724982479828923, which was allowed.

image.png

I also feel that despite the Singaporean context, the + symbol should be allowed for international patients. eg. +88 82738492 does not work: edit S1234567B p\+88 89274892

Without space in-between numbers image.png

Thank you! :)


[original: nus-cs2103-AY2324S2/pe-interim#5262] [original labels: severity.Low type.FeatureFlaw]

Jayne1010 commented 5 months ago

Team's Response

Thanks for pointing this out, while we disagree with the input validation (we wanted to prevent overzealous checking), we do agree that the + symbol might be useful, which was something we did not think about. Good catch!

Duplicate status (if any):

--