search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Wrong email format is supported #5562

Open nus-se-script opened 1 month ago

nus-se-script commented 1 month ago

image.png It should not support this type of email. like 123@123

[original: nus-cs2103-AY2324S2/pe-interim#5539] [original labels: severity.Low type.FeatureFlaw]

wang-xinrong commented 4 weeks ago

Team's Response

Under QnA for what can be fixed for PED bugs: [Q5] Can we tweak validity checks for a user input, or error/exception handling? A: • Can be allowed only if the current behavior causes the software to misbehave (i.e., crash, give incorrect results, store inconsistent data, or make it unusable for typical users). • Accepting seemingly 'unsuitable' values for an input (e.g., accepting numbers for a person name, empty value as a parameter): This is not considered 'incorrect' (giving more freedom to the user is not necessarily incorrect) unless those unsuitable values causes the application to misbehave. • Accepting supposedly invalid values (e.g., end date is earlier than start date; February 30th) is, while not ideal, not necessarily incorrect either (i.e., adopting a garbage-in garbage-out approach to input validation). However, if such data can make other things go haywire (e.g., crash the app, corrupt the data file), accepting them can be considered a bug, and fixed.

Although the suggestion is valid, the specified invalid input does not cause the product to misbehave, and should not be considered a bug.

Duplicate status (if any):

--