nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Edit command allows edit to be executed despite having the same inputs as the original values #743

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

Steps to reproduce

execute edit 1 c/ Test twice to ensure you're editing the company name "Test" to "Test" in the second execution of the command.

Expected

It should tell the user that nothing was edited.

Actual

It shows a success message even though nothing was changed.

Edited internship application entry: Test; Phone: 98765432; Email: HappyBurger@example.com; Address: 311, Clementi Ave 2, #02-25; Tags: Interview; Job Description: Software Developer intern; Interview Date: 29-05-2024 1200; Internship Duration: 3 months; Salary: 1000; Note: Company CEO is John Doe

image.png


[original: nus-cs2103-AY2324S2/pe-interim#592] [original labels: severity.Low type.FeatureFlaw]

eunrcn commented 2 months ago

Team's Response

This does not hinder usage of the application, we did mention in the UG that edit will simply remove the existing data and replace it with the new data. It does not matter if the old and new data is the same or not.

Screenshot 2024-04-20 at 4.59.05 PM.png

Duplicate status (if any):

--