nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Error message for invalid index can be more specific #939

Open nus-pe-bot opened 5 months ago

nus-pe-bot commented 5 months ago

Steps to reproduce

image.png

When the index is 0 or larger than the maximum integer, the error message is "Invalid command format". However, I think that the error message should be "The person index provided is invalid" like when the index is out of range.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#1201] [original labels: type.FunctionalityBug severity.Low]

felixchanyy commented 5 months ago

Team's Response

Thanks for pointing it out! The third line of the error message specifies that INDEX must be a positive integer. Zero is a non-positive integer, so the team feels that the error message provides sufficient warning.

image.png

As seen in the given PE information website, this is an extreme user behaviour, which is not considered a bug as stated in the website. https://nus-cs2103-ay2324s2.github.io/website/admin/tp-pe.html#functionality-bugs-2

image.png

Duplicate status (if any):

--