search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Name/Rename CS course does not account for all types of CS courses #99

Open nus-se-script opened 7 months ago

nus-se-script commented 7 months ago

As per the UG:

image.png The UG explains that:

Course code is meant for CS coded courses, hence only a prefix of two letters is allowed

the definition of CS coded course is not specific enough, does it refer to courses that starts with "CS" in its module code, or does it refer to courses categorized as Computer Science? If it is the latter, then upon checking the NUSMODS website, this feature does not account for the following modules, which are a small subset of counter examples as shown in the following: image.png

The team may need to add a whitelist that is counter checked with the NUSMODS website to allow these modules to be added for the functionality to be complete, in the sense that it is able to take in all "CS coded courses". Otherwise, the definition of "CS coded courses" may need to be strengthened.

[original: nus-cs2103-AY2324S2/pe-interim#130] [original labels: severity.Low type.DocumentationBug]

tituschewxj commented 7 months ago

Team's Response

There are two issues raised in this bug report, so we will keep the higher severity issue.

  1. Some Computer Science courses being not accepted, a feature flaw
  2. The definition of CS coded courses is unclear, a documentation bug

We agree that the definition of CS coded courses should be strengthened. Our intention was to only allow courses that started with CS in the course code. Since it is a bit vague, we agree that our documentation could expand on what we meant by CS coded courses. We agree that the definition of CS coded courses is unclear, which is a documentation bug. We agree that the severity is low.

Another issue is some Computer Science courses being not accepted, such as GEI1000. It falls into Computer Science faculty, but not with CS in the course code. We agree that not allowing all computer science courses makes this application less useful to a small subset of CS TAs. Since this is only a small subset of all computer science courses, it impacts only a small number of users, so this issue will be put as low.

Hence, we accept this as a feature flaw, low.

Duplicate status (if any):

--