search

nus-cs2103-AY2425S1 / forum

12 stars 0 forks source link

Use GFMD progress not updating in dashboard #360

Open sannie-beep opened 2 days ago

sannie-beep commented 2 days ago

I was wondering why my Use GFMD is tagged as not done. I had actually edited it twice, once on Wednesday morning and once this morning. The dashboard was last updated at 21:16, but I had already updated my GFMD and made a commit way before that.

Here is a screenshot of the dashboard page: Screenshot 2024-09-19 233338

Here is a screenshot of my GFMD. I have followed all the requirements entailed in the instructions for the task. Screenshot 2024-09-19 234058 Screenshot 2024-09-20 001800

Would you be able to advise on why the task has not been recorded as complete?

damithc commented 2 days ago

I had already updated my GFMD and made a commit way before that.

hmmm... this one shouldn't need any commits 🤔 😁

MAOXIONGKAI commented 2 days ago

Sorry but someone please correct me if I am wrong, I don't think this is how you should include emoji in your GFMD, you should use markdown language to specify the emoji as well instead of just copy pasting them like this, for more detail can refer to this GFMD emoji cheat sheet.

Hope this helps.

sannie-beep commented 2 days ago

Firstly, thanks for the replies!

@MAOXIONGKAI Hm, but I was following this from the Github docs on GFMD

Typing : will bring up a list of suggested emoji. The list will filter as you type, so once you find the emoji you're looking for, press Tab or Enter to complete the highlighted result. I didn't copy and paste and instead it just auto-filled it, so I'm unsure why it still didn't record.

@damithc I see, but I am still unsure as to why it didn't record in the dashboard since the updated Readme shows on my iP too, despite my commits. Becayse I seem to be meeting all the requirements listed (unless it has something to do with the emoji format). Could it perhaps be something to do with the progress tracker?😕

damithc commented 2 days ago

@damithc I see, but I am still unsure as to why it didn't record in the dashboard since the updated Readme shows on my iP too, despite my commits. Becayse I seem to be meeting all the requirements listed (unless it has something to do with the emoji format). Could it perhaps be something to do with the progress tracker?😕

@sannie-beep This requirement doesn't ask you to put GFMD in the README file (hence, no commit is needed). Instead, GFMD is expected in the PR description.

sannie-beep commented 2 days ago

@damithc Ohh, I see! I misinterpreted the task as having to edit the README, since I thought that was what the description was referring to 😅. Thanks for your patience and replies! I have now edited the description. 👍