nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Clients with the same name cannot be added #1049

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Description

I am unable to add 2 people called John Doe into the app even though all the other fields are different. The UG mentioned that people with the same name must be differentiated by changing the name inputted into the app, but this is not very feasible for common names in Singapore like Alex Tan or Alan Lee.

Screenshot 2024-11-15 at 4.34.38 PM.png

Steps to Reproduce

  1. add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 d/likes bubble tea c/Investment
  2. add n/John Doe p/90799332 e/johd@example.com a/Jon street, block 123,#01-01 d/lies bubble tea c/Invetment

Expected Output

2 clients with the same name should be able to be added into the database, and be differentiated with another more unique field

Actual Output

Screenshot 2024-11-15 at 4.33.48 PM.png


[original: nus-cs2103-AY2425S1/pe-interim#1458] [original labels: severity.Medium type.FeatureFlaw]

rubinnn commented 1 week ago

Team's Response

Thank you for pointing this out!

However, we decided not to use any other unique fields to differentiate clients with the same name due to the following reasons:

Therefore, we have to reject this issue as we believe that the current version is more optimized than the suggested implementation because it will increase the efficiency of the FA's workflow.

Duplicate status (if any):

--