search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Wrong command result for hire and reject #1055

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

The user guide states that name and job are case-insensitive for hire and reject command. Screenshot 2024-11-15 at 4.51.51 PM.png

Steps to reproduce:

  1. Start with default data
  2. Type command hire n/Bernice j/software engineer

Actual:

Screenshot 2024-11-15 at 4.49.09 PM.png

Expected: In the contact list, I have Bernice Yu with the job of Software Engineer. However, when executing hire n/Bernice j/software engineer, I get the error Error: Job not found.. This is however wrong especially since job is supposed to be case-insensitive.

Also, it is worth mentioning that when I modify the command to match the casing of the job: hire n/Bernice j/Software Engineer, I get this command result instead.

Screenshot 2024-11-15 at 4.54.27 PM.png

This is arguably the more accurate command result which is shown when I match the casing for the job.

[original: nus-cs2103-AY2425S1/pe-interim#1466] [original labels: severity.Medium type.FunctionalityBug]

LemonDrew commented 1 week ago

Team's Response

This is already stated under "Planned Enhancements", hence we will reject this.

image.png

Duplicate status (if any):

--