nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

I can add multiple tutors with the same phone number #1109

Open nus-pe-bot opened 1 day ago

nus-pe-bot commented 1 day ago

Steps to reproduce: run "addTutor \n John Doe \p 98765432 \e johndoe@example.com \a Clementi, 123456 \h 6 \s Math" run "addTutor \n Doe \p 98765432 \e johndoe@example.com \a Clementi, 123456 \h 6 \s Math"

Expected result: Duplicate phone number in Doe and unable to add him to the app. Actual result: Both members are added to the app. Additional info: I would not expect two distinct tutors to have the same phone number so this should be checked.


[original: nus-cs2103-AY2425S1/pe-interim#1543] [original labels: severity.Medium type.FeatureFlaw]

Plishh commented 5 hours ago

Team's Response

The same phone number can be accepted, as the contacts saved may be kids and do not have their own phone numbers, 2 siblings may both use one of their parent's phone numbers. Therefore 2 are only considered duplicates if both their name and phone number are the same.

Duplicate status (if any):

--