search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

App will not return correct error if the user tries adding an entry with date before 2000 #1194

Open nus-se-script opened 2 weeks ago

nus-se-script commented 2 weeks ago

As stated in the UG, the DATE when adding an entry must be within the year 2000 and the current year. However, the format for DATE is dd/mm/yy, which means that the app will not know if the user wanted to input a date before 2000.

image.png

As a result, if the user wants to add an entry with a year before 2000 but with last two digits after the current year's, (e.g. d/21/10/99), it assumes that the user wanted to input 2099 and the error returned only states that the date cannot be in the future.

image.png

This does not correspond appropriately with the restrictions specified in the UG, and does not provide the user with the correct message in response to what they intended to do.

Perhaps we could change the year input to YYYY instead of YY, that way we can differentiate between future dates and dates before 2000?

[original: nus-cs2103-AY2425S1/pe-interim#1660] [original labels: severity.Low type.FunctionalityBug]

ZweZeya commented 2 weeks ago

Team's Response

We reject this for the following reasons:

  1. 21/20/99 will be interpreted as the year 2099 which is a date in the future. Hence, the error message aligns with the user input.
  2. In our UG, we specified that DATE must be within the year 2000 and the current year, hence there is no need to differentiate between future years and years before 2000.
  3. Our app is intended to be used by students to track internship applications, and hence it does not make sense for the user to add dates in the future or far in the past.
  4. This behaviour does not cause inconvenience to our users.

Duplicate status (if any):

--