nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

tag/untag vs edit tag #12

Open nus-se-script opened 2 weeks ago

nus-se-script commented 2 weeks ago

Using the edit command to edit the tags resets the tags to whatever the user inputs while the tag command does not. Since you have the tag command, it might be better to remove the ability to edit tags from the edit command as it may cause unnecessary confusion to the user, leading to them unintentionally resetting the tags. An additional suggestion might be to add a cleartag command to clear all the tags in place of using the edit command.


[original: nus-cs2103-AY2425S1/pe-interim#16] [original labels: severity.Medium type.FeatureFlaw]

SuhailLoya commented 2 weeks ago

Team's Response

Edit functionality edits the person -> so overwriting the tags make sense

Tag means we are tagging a person -> so adding the tag makes sense.

The UG has made this very clear already.

However, you do make a valid point. Since we already have a tag/untag functionality, ability to edit tags in edit command might be redundant. Currently, the only value it is providing is the ability clear tags very fast using edit <index> t/. However as you mentioned a separate command can be created for that. However, this is a lot of effort, just to restructure existing functionality which is already clear enough and described by the UG. This was not important enough to be done by v1.6 (not in scope).

Duplicate status (if any):

--