nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Filter doesn't actually filter the list #1208

Open nus-pe-bot opened 6 days ago

nus-pe-bot commented 6 days ago

Issue name

Filter doesn't filter the list of contacts

To reproduce

  1. Use the filter command

Expected behavior

I understand it isn't supposed to, but intuitively a user would probably want it to filter the list anyway.

Severity

By giving only the index and name, this is basically inconveniencing the user to find those users himself.


[original: nus-cs2103-AY2425S1/pe-interim#1675] [original labels: severity.Medium type.FeatureFlaw]

travisim commented 4 days ago

Team's Response

Intention

The command would have been more appropriately named filterpa instead of filter.

We intended the filter command to primarily focus on public address management, as outlined on page 19 of the user guide.

A reasonable user would typically expect to search for contacts rather than filter them. For example, a cryptocurrency user might use a filter to identify contacts with specific crypto public addresses, such as ETH, in order to add them to blockchain-based social media platforms.

Screenshot 2024-11-18 at 8.36.26 PM.png

Severity

The severity is low because the command works as intended and aligns with the user guide. While the name filter may cause slight confusion, users can still perform the intended functionality without disruption. The impact is minor and unlikely to affect normal operations, making it a minor inconvenience rather than a significant issue.

Duplicate status (if any):

--