nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

No way to edit existing tutorial information, and deleting tutorial group wipes all attendance records. #1272

Open nus-pe-bot opened 2 days ago

nus-pe-bot commented 2 days ago

Description

As a tutor, if I want to delete a tutorial group (maybe because the name of the tutorial was input wrongly), there is no way for me to easily edit the tutorial group's name or ID.

If I wanted to change the name of the tutorial, I would have to delete the tutorial and add all the students back into the same tutorial group again.

This would require manually adding back each student using the edit command, which is cumbersome.

Furthermore, when a tutorial group is removed, all the past attendances of students are removed as well.

This behaviour is also not reflected in the user guide for deleteTut, which can be misleading and lead to critical loss of data, especially since the action is irreversible.

Steps to Reproduce

  1. Create a new tutorial group, e.g. with ID T0001
  2. Add two students to the tutorial group, e.g. StdA and StdB
  3. Mark the attendance for the two students (doesn't matter which day)
  4. Delete the tutorial group created in step 1
  5. Observe that the attendances for the two students are deleted and there is no way to retrieve those results.

Screenshots

Before deleting the tutorial group

Screenshot 2024-11-15 at 5.01.24 PM.png

After deleting the tutorial group

Screenshot 2024-11-15 at 5.01.50 PM.png

Implications

This means that tutors are 'locked' in to the ID and name of the tutorial group when it was initially created, and there is no way for them to edit the details if they made a mistake.

This is especially so if there were already a few attendances marked – the tutor has no way to edit the incorrect information, unless he or she wants to manually create a new tutorial group and add back the students one by one, and additionally mark each of the deleted attendances one by one.


[original: nus-cs2103-AY2425S1/pe-interim#1761] [original labels: severity.Medium type.FeatureFlaw]

waihongteh commented 1 day ago

Team's Response

Firstly, to clarify, we are only picking the first issue that you raise here, which is "No way to edit existing tutorial information" following the rules in CS2103T.

image.png

This is an intended behaviour of our application. We had a discussion on this before but decided that we are not implementing this feature in current version, but rather in the future. The reasons are as follow:

  1. We do not find it creating any inconvenience as it is very rare to edit an existing tutorial. This follows the NUS setting where tutorial names do not change in the semester, hence a downgrade to severity.low.
  2. More importantly, there is a workaround which is that users can delete and re-create a tutorial class with the intended name and add the attendance again.
  3. We also try to make tutorials immutable to ensure that no data is edited accidentally.

Duplicate status (if any):

--