nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Unable to Schedule Lesson due to existing Clash with MakeUp Lesson #1302

Open nus-se-script opened 6 days ago

nus-se-script commented 6 days ago

According to the UG, only regular lessons should be weekly occuring, which appears in the calendar on the side. Makeup lessons should only occur once on the specified days, and do not appear in the calendar.

image.png

image.png

As such, I expect to be able to schedule regular weekly lessons. However, I'm unable to schedule a lesson due to an existing clash with a ONE-TIME Makeup Lesson on the 25-10-24.

Command: schedule 8 d/Friday st/11:00 et/12:00 Expected: Student 8 has Lesson Scheduled on Friday 11:00 to 17:00 Result: Command Result Display Notifies me that there is an existing clash on 25-10-2024

image.png


[original: nus-cs2103-AY2425S1/pe-interim#1800] [original labels: severity.Medium type.FeatureFlaw]

IzN432 commented 4 days ago

Team's Response

Firstly, make up lessons do show up on the calendar view. The view is set to Nov 11 to Nov 17, which is not the week containing the makeup lesson you mentioned.

Secondly, it is expected behaviour, as the user should be warned if they have a makeup lesson on a date that they are trying to schedule a new weekly lesson on. For e.g, student A has makeup lesson next Thursday. If I am scheduling a weekly lesson with student B on Thursday at the same time, then I should be warned that it clashes.

image.png

Thirdly, if your issue is with makeup lessons in the past preventing you from scheduling weekly lessons, then this is included in our planned enhancements.

Duplicate status (if any):

--