search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Multiple spaces between name inputs are allowed. #1323

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

The name is truncated with the ... symbol. The VIP tag is also gone with the ... symbol.

Names with multiple spaces in between words is allowed as a valid input, this causes infinitely long names to be truncated and displayed incorrrectly.

Let's say a user accidentally adds John Doe with 2 spaces in between, and tries: delete John Doe

He will not be able to delete it and might not know the reason why.

Screenshot 2024-11-15 165714.png

[original: nus-cs2103-AY2425S1/pe-interim#1828] [original labels: severity.Low type.FunctionalityBug]

engyuhan commented 6 days ago

Team's Response

Changed to severity.VeryLow.

Of the potential problems mentioned, "Let's say a user accidentally adds John Doe with 2 spaces in between, and tries: delete John Doe" is not valid, since a person whose name has 2 spaces is different from a person whose name has 1 space. It is much worse if a customer is deleted, whose name was not even typed in the command.

The truncation is merely a cosmetic issue, since all the functionality is retained. It is possible to determine the customer is a VIP just by the red tag, since only VIPs have it.

Duplicate status (if any):

--