nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Able to add a past date for Contract-End-Date field #1396

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Currently able to add a contract end date with a past date (e.g. 2020-01-01) which is counter-intuitive given the context of managing potential hires and employees. Not restricting this seems to bring more harm than good since the target user would likely not want to input an incorrect contract end date that is in the past (since the contract should not have ended yet).

Screenshot 2024-11-15 at 5.24.04 PM.png I understand that this would give additional flexibility to users (as mentioned above), but the given flexibility could possibly result in more errors of inaccuracy for the target users. Not sure when the target user would want to document past employees or when this flexibility would be useful given the context (perhaps could mention/elaborate in the user stories?).


[original: nus-cs2103-AY2425S1/pe-interim#583] [original labels: severity.Medium type.FeatureFlaw]

thortol commented 1 week ago

Team's Response

Reason for dropping to severity low

This issue is should be a low as the user intentionally added contract end dates in the past which is a rare situation as they intentionally inputted inaccurate data.

Reason for not in scope

Mentioned in the UG as not supported.

image.png

Duplicate status (if any):

--