nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

editing fee of a student who has already paid doesn't show a warning / give an error and automatically change the revenue #1514

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

Description Currently, if i have a student who has been marked as paid already, and I edit the student to increase/decrease his fee. There is no warning showed, and the total revenue is directly changed by the App.

Steps to reproduce From sample data, mark a person as paid -> here i marked charlotte

Screenshot 2024-11-15 at 5.06.26 PM.png

Calculate revenue using revenue paid

Screenshot 2024-11-15 at 5.06.58 PM.png

Shows 100.

Edit charlotte's fee using edit 1 f/1000

calculate revenue using revenue paid again

Screenshot 2024-11-15 at 5.09.13 PM.png

Actual Output: Charlotte remains marked as paid and revenue is automatically adjusted to $1000 (we don't know if the difference has been paid yet).. Expected Output: A warning is displayed saying the person is marked as paid, asking if we want to unmark the person / adjust according to the amount paid alr etc..

This is a major bug, in this feature as it may show inaccurate results for money-related matters which is a sensitive and important topic. Money handling should be very carefully done, and I feel this bug makes the product unreliable for most users. Hence severity high


[original: nus-cs2103-AY2425S1/pe-interim#2089] [original labels: severity.High type.FunctionalityBug]

josh1248 commented 1 week ago

Team's Response

This is actually the intended use case of the fees field to highlight the outstanding fees of the user - for example, that the fees have increased from 100 to 1000 which the student has yet to pay. The tester has mentioned a suggestion that is not a functionality bug of our app.

Duplicate status (if any):

--