search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Cluttered Model Class Diagram #1574

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Section found: Model Component

image.png Class diagram is quite cluttered and contains some unnecessary low level details (e.g. composition relations with Name, Phone, etc)

Suggestion: Split the class diagram into two or more diagrams, one showing the necessary high level components, the other showing the lower level details.

[original: nus-cs2103-AY2425S1/pe-interim#2167] [original labels: severity.Low type.DocumentationBug]

karthickkc commented 1 week ago

Team's Response

Hi thanks for the suggestion, we understand that a few people may find the diagram a little messy. However, this is a plant UML limitation and there was no easy fix for this issue. If we were to remove certain details from this diagram, there would be important information lost. There was no easy way to split the information as there are no low levels details, the details are on the same level. Composition relations with name and phone are essential for the Person and Concert classes.

Duplicate status (if any):

--