nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Clean command do not show error message #1631

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

image.png When executing clean when there is no person that already graduated, can be done by executing clear command twice, error message is expected but there is none.

image.png


[original: nus-cs2103-AY2425S1/pe-interim#2246] [original labels: severity.Low type.FunctionalityBug]

EdaYeo commented 1 week ago

Team's Response

We categorized this bug as not in scope as there is already an error message. The clean command is changed to red in the command box, indicating that the command has not been executed. As red is a common convention to show an error, and we used the same red to indicate when all our other commands have errors, this should signal to the user that the command was not executed. Furthermore, the error message states "All graduated students have already been deleted", indicating that the deletion was in the past.

While we agree that this could have been phrased better by writing "There are no graduated students to delete", we believe that this does not hinder the user as it is sufficiently clear the command was not executed, and as the end result is the same, with no graduated students left within the address book.

Duplicate status (if any):

--