search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Adding of Budget does not allow for spaces in the numbers #1908

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Summary

Spaces between numbers throws an error.

Expected Behavior: Should still accept numbers with spaces because UG and error messages do not explicitly say its not allowed

Actual Behavior: Invalid input

Steps to Reproduce

  1. add n/Jon Doe p/98765432 e/johnd@example.com b/120 000 t/friends t/owesMoney

  2. Error message thrown

Screenshots

image.png

image.png

Reasoning for Severity

This can be both a feature flaw and functionality bug. Both the error thrown in the application and also the acceptable paramters in the UG has the same message regarding the budget. So when i try to add 120 000, users may expect it to be accpeted as some people type numbers with spaces to see the order of magnitude easily. Both the error message thrown and UG could have be improved if this was the inteded usage or the parser could take in number with spaces as in improvement for this feature. Some users may find these an issue and may hinder their usage so it will be assigned medium severity.

[original: nus-cs2103-AY2425S1/pe-interim#808] [original labels: severity.Medium type.FeatureFlaw]

KennyLewi commented 1 week ago

Team's Response

This is rejected as it is mentioned in the command instructions that only numbers and commas are accepted as input. Moreover, it is unconventional to use whitespaces when inputting numbers digitally for a budget.

Duplicate status (if any):

--