nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

find can take both name and tag #1973

Open nus-se-script opened 6 days ago

nus-se-script commented 6 days ago

from the UG: following find KEYWORD [MORE_KEYWORDS] , I would assume that find alex tag seller will find for me all the client whose names contain "alex", "tag" or "seller". But in this case, it also finds contact whose tags contain "seller".

find KEYWORD [MORE_KEYWORDS]

To prevent such a confusion and to make your commands more clear, a different command should be used instead like find-tag or now allow the mix of finding names and tags together.


[original: nus-cs2103-AY2425S1/pe-interim#2706] [original labels: type.FeatureFlaw severity.Low]

tayxuenye commented 4 days ago

Team's Response

Thank you for your bug report. However, our team concluded that this is not a bug. It is specifically stated in the UG under point 3 that the “find” command can search for keywords such as name, email, address, and tags.

Screenshot 2024-11-18 141011.png

Additionally, we wanted to allow more flexibility in the searching, so let’s say the user wants to search for a partial name that he or she knows has a specific tag, such as “Buyer”. This added flexibility allows for more refined searches such as the filters you would expect out of data processing applications.

Duplicate status (if any):

--