nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Phone Numbers length is too long #213

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

According to this World Population Review, "Phone number length around the world ranges from 17 digits to only 4."

However, in your error message, you accept a range of 3-20 digits long as seen below.

Screenshot 2024-11-15 at 16.30.04.png

Now I understand that this is a very minor bug but maybe you could implement a way that allows users to set a cap on the number of digits, just in case the user accidentally keys in a Singapore phone number with a lower or higher digit count such as 9876543 or 987654321 respectively. Cause in the event the user then goes back to see the contact/vendors phone number, its wrong and they have to scramble to find it again.


[original: nus-cs2103-AY2425S1/pe-interim#302] [original labels: type.FeatureFlaw severity.VeryLow]

leslieyip02 commented 1 week ago

Team's Response

This is a good suggestion, but it was not a priority for v1.6.

Duplicate status (if any):

--